huggingface / huggingface/diffusers

Split Q,K,V vs Fused QKV Projections in diffusers Discussion

Open
#14,003 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
34.5k
Forks
7.3k
Avg merge
3d 3h
Merged PRs (30d)
91

Description

`diffusers` generally splits fused QKV projections to separate Q, K, V projections in its checkpoint format (for example, for diffusion transformer models). I am interested in collecting feedback on this design choice and any problems which may arise from it. To be honest upfront, I think it is unlikely that we will change this design in the near future, but we would appreciate your feedback nevertheless.

EDIT: the reasoning for using split Q, K, V projections is described in more detail in https://github.com/huggingface/diffusers/issues/14003#issuecomment-4774944332.

Contributor guide

Open the contributing guide

Research direction

Start with the issue body and the linked comment, which explain the split Q, K, V versus fused QKV checkpoint-design rationale. No files, tests, entry points, implementation target, or completion criteria are identified; done is not defined beyond collecting feedback on the design.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.