huggingface / huggingface/diffusers

Why does calculate_dimensions in qwen-image-edit require image height/width to be multiples of 32?

Open
#12,997 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
34.5k
Forks
7.3k
Avg merge
3d 3h
Merged PRs (30d)
91

Description

Hi, thanks for the great work!
I have a question regarding the logic in calculate_dimensions.
Currently, the image height and width are constrained to be multiples of 32.
From my understanding:
The VAE has a downsampling factor of 8, so the latent spatial size should require the input dimensions to be multiples of 8.
Before entering the DiT, the latent is passed through a Patch Embedding layer with patch_size = 2.
That would further imply a total factor of 8 × 2 = 16.
Based on this, it seems that constraining the image dimensions to be multiples of 16 should already be sufficient.

Could you clarify why a multiple of 32 is required here?
Is there an additional downsampling stage, architectural constraint, or implementation detail that I might be missing?
Thanks in advance for the clarification!

Contributor guide

Open the contributing guide

Research direction

Start by locating calculate_dimensions in qwen-image-edit and tracing the VAE, latent, DiT, and Patch Embedding stages mentioned in the issue. Check whether any additional architectural or implementation constraint explains the multiple-of-32 requirement. Done means documenting a clear explanation of the constraint, including whether multiples of 16 are sufficient.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.