huggingface / huggingface/diffusers
Modular guiders should provide sane defaults
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 34.5k
- Forks
- 7.3k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 91
Description
Modular guiders are a great concept, but right now they are nearly impossible to use due to sane lack of default values.
For example, PerturbedAttentionGuidance requires either SkipLayerGuidance: List[int] param or perturbed_guidance_config: LayerSkipConfig param
There are no chance that normal user would know any of such deep internals. Ask is to provide default values and any such params should be optional.
cc @yiyixuxu @sayakpaul @DN6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the definitions and call sites for PerturbedAttentionGuidance and LayerSkipConfig, then inspect how modular guiders are instantiated without explicit configuration. Determine which parameters can be optional and what defaults preserve normal-user behavior; done means a guider can be created without either deep-internal argument and the relevant existing behavior remains covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100