huggingface / huggingface/diffusers

SD3.5-Controlnet-8b does not use encoder_hidden_states

Open
#11,902 4 comments 0 reactions 0 assignees View on GitHub
stale
Dominant language
Python
Stars
34.5k
Forks
7.3k
Avg merge
3d 3h
Merged PRs (30d)
91

Description

In https://github.com/huggingface/diffusers/blob/main/examples/controlnet/train_controlnet_sd3.py#L1338
the encoder_hidden_states are set to prompt_embeds, which is incorrect if we are finetuning sd3.5-controlnet-8b since it does not use encoder_hidden_states as stated in https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/controlnets/controlnet_sd3.py#L406

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.