huggingface / huggingface/datatrove

Support int32 in substring dedup

Open
#118 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3.3k
Forks
302
Avg merge
2h 18m
Merged PRs (30d)
2

Description

I'm using a tokenizer with > 100k vocab size, so the token id overflow as it is stored in uint16. I'm wondering if we can add support for int32? Is it possible to simply change the type or is there other places that need to be changed?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the substring dedup implementation and trace where token IDs are stored as uint16, including the tokenizer path mentioned in the issue. Done means int32 IDs work for vocabularies over 100k without overflow; the issue does not name specific files or tests, so identify the affected coverage while tracing the implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.