huggingface / huggingface/dataset-viewer

Differentiate between `NaN` and `null` in the viewer

Open
#2,828 7 comments 1 reaction 1 assignee Claimed by @polinaeterna View on GitHub
P1
Dominant language
Python
Stars
899
Forks
130
Avg merge
9h 26m
Merged PRs (30d)
14

Description

Currently, we don't do this and display and return in response `null` in both cases.
From the discussion in https://github.com/huggingface/dataset-viewer/pull/2797, this is agreed that it's important to let users know how to correctly treat data with these values.
This would require:
- [ ] Change in how we transform parquet to /first-rows and /rows response. I haven't figured out where exactly, but apparently `nan` values are somehow replaced with `null`.
- [ ] Change in response structure and field names in /statistics - for float columns add field `nan_count`, for other columns rename `nan_count` to `null_count` :/// (my bad with the original naming)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.