huggingface / huggingface/computer-vision-course
z-axis rotation matrix not right in Basics of Linear Algebra for 3D Data
- Dominant language
- Jupyter Notebook
- Stars
- 881
- Forks
- 242
- Avg merge
- 2m
- Merged PRs (30d)
- 1
Description
First of all thanks for this course :)
Please note that in [Basics of Linear Algebra for 3D Data](https://github.com/johko/computer-vision-course/blob/main/chapters/en/unit8/terminologies/linear-algebra.mdx) when introduced the z-axis rotation matrix it is a copy of the y-axis one.
Now it is:
```
- Rotation around the Y-axis
$$ R_y(\beta) = \begin{pmatrix} \cos \beta & 0 & \sin \beta & 0 \\ 0 & 1 & 0 & 0 \\ -\sin \beta & 0 & \cos \beta & 0 \\ 0 & 0 & 0 & 1 \end{pmatrix} $$
We are sure you can use the example snippet above and figure out how to implement a rotation around the Y-axis.😎😎
- Rotation around the Z-axis
$$ R_y(\beta) = \begin{pmatrix} \cos \beta & 0 & \sin \beta & 0 \\ 0 & 1 & 0 & 0 \\ -\sin \beta & 0 & \cos \beta & 0 \\ 0 & 0 & 0 & 1 \end{pmatrix} $$
Again, can you use the last code snippet and implement a rotation around the Z-axis❓
```
Should be:
```
- Rotation around the Y-axis
$$ R_y(\beta) = \begin{pmatrix} \cos \beta & 0 & \sin \beta & 0 \\ 0 & 1 & 0 & 0 \\ -\sin \beta & 0 & \cos \beta & 0 \\ 0 & 0 & 0 & 1 \end{pmatrix} $$
We are sure you can use the example snippet above and figure out how to implement a rotation around the Y-axis.😎😎
- Rotation around the Z-axis
$$ R_z(\beta) = \begin{pmatrix} \cos \beta & -\sin \beta & 0 & 0 \\ \sin \beta & \cos \beta & 0 & 0 \\ 0 & 0 & 1 & 0 \\ 0 & 0 & 0 & 1 \end{pmatrix} $$
Again, can you use the last code snippet and implement a rotation around the Z-axis❓
```
Thanks again
Contributor guide
Assessment
This issue has not been assessed yet.