huggingface / huggingface/candle

Consider merging `cuda` and `cudnn` features

Open
#3,399 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
21k
Forks
1.8k
Avg merge
16h 42m
Merged PRs (30d)
25

Description

Currently, `cuda` and `cudnn` are separate features, that implement many of the same kernels in different ways.
This results in duplicated effort on candle's part, more configuration flags, more kernels, more complicated control flow in candle - all to support `cuda` without `cudnn` separately from `cuda` with `cudnn`.

Most mainstream ML frameworks (pytorch, tensorflow, jax) just assume cuda + cudnn as a dependency together, avoiding the duplicated effort.

I suggest candle should merge `cudnn` and `cuda` configuration flags together, and always require `cudnn` on `cuda` hosts.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.