huggingface / huggingface/candle

Add docs for argmax_keepdim and specify what happens in the event of a tie

Open
#1,917 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
21.1k
Forks
1.8k
Avg merge
16h 42m
Merged PRs (30d)
25

Description

argmax_keepdim has no documentation, which would be good to fix in general, but especially to resolve the question of what occurs when there are multiple elements along the target dimension that are tied for the max.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the argmax_keepdim entry point and its existing documentation or nearby argmax documentation. Check the current behavior when maximum values tie, then document argmax_keepdim and state the tie behavior clearly. Done means the API has documentation covering both the operation and ties.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
documentation, machine-learning
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.