http-rs / http-rs/tide

Rewrite Multipart support using `multipart-async`

Open
#89 3 comments 9 reactions 0 assignees View on GitHub
feature
Dominant language
Rust
Stars
5.1k
Forks
329
PR merge metrics
No merged PRs in 30d

Description

@liufuyang did an excellent job implementing the current multipart support and I'm flattered he chose my crate, but I'm worried about the scalability of collecting the entire request body to `Vec`, as you typically don't want to keep whole files in memory.

I have [`multipart-async`](https://github.com/abonander/multipart-async) which is designed to parse a multipart body from an async stream but it has languished a bit as I was waiting for the futures churn to settle and then I kind of forgot about it.

I'll be coming back to it and fixing it up, and I'd be glad to consult on/mentor a refactoring of Tide's multipart support to use it, or even another crate if there is one.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.