http-rs / http-rs/surf

Turn on TCP NO_DELAY by default?

Open
#322 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

semver-major
Dominant language
Rust
Stars
1.5k
Forks
128
PR merge metrics
No merged PRs in 30d

Description

@ericsampson mentioned to me that a lot of http clients turn this on by default.

Some ecosystem stats:
- [Node.js does this by default on sockets](https://nodejs.org/dist/latest-v16.x/docs/api/net.html#net_socket_setnodelay_nodelay)
- [Reqwest does this by default](https://docs.rs/reqwest/0.11.4/reqwest/struct.ClientBuilder.html#method.tcp_nodelay)
- [Hyper itself has this as `false`](https://docs.rs/hyper/0.14.11/hyper/client/struct.HttpConnector.html#method.set_nodelay)
- [libcurl also does this by default](https://curl.se/libcurl/c/CURLOPT_TCP_NODELAY.html)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing where Surf establishes TCP connections, then review the linked Node.js, Reqwest, Hyper, and libcurl behavior; done means the default TCP_NODELAY behavior is clearly decided, implemented, and covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.