http-rs / http-rs/surf

surf middleware logging does not print the actual response status

Open
#188 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.5k
Forks
128
PR merge metrics
No merged PRs in 30d

Description

Hi,

It was observed that the surf::middleware::logger::native module is not printing the http status when a client or server error happens. Below is the sample log we get.

_2020-06-09T13:43:04.016939833+00:00 ERROR surf::middleware::logger::native - request completed
2020-06-09T13:43:04.647317060+00:00 ERROR surf::middleware::logger::native - request completed
2020-06-09T13:43:07.933639018+00:00 ERROR surf::middleware::logger::native - request completed
2020-06-09T13:43:08.811188678+00:00 ERROR surf::middleware::logger::native - request completed
2020-06-09T13:43:08.838813369+00:00 ERROR surf::middleware::logger::native - request completed_

Looking at the code it looks like it is supposed to print the status as well. We are using 2.0.0-alpha.1 version. Please advise. Thanks

Contributor guide

Open the contributing guide

Research direction

Start in the surf::middleware::logger::native module and reproduce a client or server error using the reported logging setup. Inspect how the completed request status is obtained and compare it with the emitted log; done means error responses print their actual HTTP status instead of only “request completed”.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.