http-rs / http-rs/surf

re-export client types and `isahc::Error`

Open
#110 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.5k
Forks
128
PR merge metrics
No merged PRs in 30d

Description

As it stands, `Client`, `Client` and friends are not nameable by consumers of the crate, which causes issues if the user wants to put a client in a struct.

Additionally, `IsahcClient` wraps `isahc::Error` into `Exception`, so if you want to downcast you need to add the right version of `isahc` as a dependency: https://www.reddit.com/r/rust/comments/dy273n/hey_rustaceans_got_an_easy_question_ask_here/f8badd4/

(I'm posting this before that user has replied so I'm not 100% sure if that's the problem they're running into.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.