http-rs / http-rs/http-types

remove `impl<E> From<E> for Error where E: StdError + Send + Sync + 'static`

Open
#108 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
209
Forks
91
PR merge metrics
No merged PRs in 30d

Description

This might a bit controversial but I'd like to bring it up. I want to suggest to remove the generic `From`.

The reason being the following:

As long as this generic implementation exists it is not possible for errors as defined by users of this library to implement their own `Into` implementations, this makes it hard to use when you need non-generic 500 error codes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.