The IsahcClient timeout setting is not a connection timeout
- Dominant language
- Rust
- Stars
- 118
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
I believe the timeout that can be set through http_client refers to the connection timeout. And I think the process shown below sets a timeout on isahc. According to the [isahc documentation](https://docs.rs/isahc/0.9.14/isahc/config/trait.Configurable.html#method.timeout), it is not the connection timeout that can be set with timeout(). The connection timeout can be set with [connect_timeout()](https://docs.rs/isahc/0.9.14/isahc/config/trait.Configurable.html#method.connect_timeout).
https://github.com/http-rs/http-client/blob/3c0ed9a2f350749f48f579867139dd9e3afdf182/src/isahc.rs#L90
https://github.com/http-rs/http-client/blob/3c0ed9a2f350749f48f579867139dd9e3afdf182/src/isahc.rs#L118
Contributor guide
Assessment
This issue has not been assessed yet.