http-rs / http-rs/http-client

The IsahcClient timeout setting is not a connection timeout

Open
#103 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
118
Forks
54
PR merge metrics
No merged PRs in 30d

Description

I believe the timeout that can be set through http_client refers to the connection timeout. And I think the process shown below sets a timeout on isahc. According to the [isahc documentation](https://docs.rs/isahc/0.9.14/isahc/config/trait.Configurable.html#method.timeout), it is not the connection timeout that can be set with timeout(). The connection timeout can be set with [connect_timeout()](https://docs.rs/isahc/0.9.14/isahc/config/trait.Configurable.html#method.connect_timeout).
https://github.com/http-rs/http-client/blob/3c0ed9a2f350749f48f579867139dd9e3afdf182/src/isahc.rs#L90
https://github.com/http-rs/http-client/blob/3c0ed9a2f350749f48f579867139dd9e3afdf182/src/isahc.rs#L118

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.