ignore ENOTSUPP (524) for fiemap error
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 200
- Forks
- 85
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 2
Description
In mfu_flist_copy.c:mfu_copy_file_fiemap()
if (ioctl(mfu_src_file->fd, FS_IOC_FIEMAP, fiemap) < 0) {
if (errno == ENOTSUP) {
/* silently ignore */
} else {
MFU_LOG(MFU_LOG_ERR, "fiemap ioctl() failed for src '%s' (errno=%d %s)",
src, errno, strerror(errno));
}
goto fail_fiemap;
}
When errno is ENOTSUP (95) the error message is skipped, but otherwise the behavior is the same. However lustre often returns ENOTSUPP (524) as mentioned in #545. I think that (errno == 524) should be silently ignored as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open mfu_flist_copy.c and inspect mfu_copy_file_fiemap(), especially the errno check around the FS_IOC_FIEMAP ioctl. Confirm the intended behavior against the existing issue context for Lustre, then verify that ENOTSUPP is treated like ENOTSUP without changing other fiemap errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100