Export of inconsistent internal headers
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 200
- Forks
- 85
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 2
Description
The header file mfu_flist_internal.h gets installed (distributed) with the compiled library. (Is this intentional? Why is it called "internal" then?) Anyway, unfortunatelly it is being included by the utils/tools/h5dwalk/h5dwalk.c file (from the HDF5 1.14 project). However, mfu_flist_internal.h unconditionally includes strmap.h, which is not being installed. And that is an error. Either both or none of them should be installed (distributed). If the functions/structures in the mfu_flist_internal.h are supposed to be used externally (like apparently they are in HDF5), then strmap.h has to be installed (distributed) too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the installation rules for mfu_flist_internal.h and strmap.h, then review how utils/tools/h5dwalk/h5dwalk.c uses the internal header. Confirm whether both headers are intended to be distributed or neither, and verify that the chosen arrangement lets the HDF5 h5dwalk source build without a missing-header error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100