support 1024 based sizes (e.g. 4MiB)
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 200
- Forks
- 85
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 2
Description
For example:
$ dcp --bufsize 4MiB src dst
ERROR: Failed to parse block size: '4MiB'
$ dcp --bufsize 4MB src dst
# Works!
$ dcp --bufsize 4M src dst
# Works!
And it appears the MiB sizes are actually used anyway:
https://github.com/hpc/mpifileutils/blob/be4e71548e04cc2c0903938fd1ca85e4cdd07518/src/common/mfu_util.c#L350-L368
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/common/mfu_util.c around lines 350-368 and trace the size parser used by dcp --bufsize. Reproduce the 4MiB, 4MB, and 4M examples, then verify that 1024-based sizes such as 4MiB are accepted and interpreted consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100