mfu_debug_level usage
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 200
- Forks
- 85
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 2
Description
Generally, most tools set mfu_debug_level = MFU_LOG_VERBOSE by default, and have a -q option which sets mfu_debug_level = MFU_LOG_NONE.
But there are several levels defined:
https://github.com/hpc/mpifileutils/blob/05055d2ad2f99291af96cd863ae59dec3d328657/src/common/mfu_util.h#L63-L71
Some tools have a hidden -d option which allows setting a specific level.
- It would be useful to be able to pass
-q, but still see errors, sinceMFU_LOG_NONElogs NOTHING. - Maybe we could more generically name
mfu_debug_leveltomfu_log_level- Or something different, since the enum is named
mfu_loglevel
- Or something different, since the enum is named
- Maybe passing
-qcould just bump the log level down by one, instead of all the way toMFU_LOG_NONE. Then, it could be possible to pass something like-qqqto increasingly decrease the log level. - Along with this, maybe we can change tools from using a default of
MFU_LOG_VERBOSEto using a default ofMFU_LOG_INFO, since most do have a-voption which at this point doesn't really do anything. Also, most messages printed areMFU_LOG_INFOmessages. - To incorporate all of this, we might want to evaluate some of the existing
MFU_LOG_INFOmessages and possibly change them toMFU_LOG_VERBOSE
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/common/mfu_util.h at the mfu_loglevel definitions referenced in the issue, then inspect how the tools handle -q, -d, and -v. The issue contains several possible designs rather than one defined change, so done requires agreeing on logging-level semantics, naming, defaults, and which messages change before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli, tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100