dcp: mfu_flist_copy.c doesn't propagate errors from mfu_copy_set_metadata
Open
Nobody has claimed this yet.
question
- Dominant language
- C
- Stars
- 200
- Forks
- 85
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 2
Description
mfu_flist_copy.c doesn't propagate errors from mfu_copy_set_metadata in any of the functions that call mfu_copy_set_metadata, even though mfu_copy_set_metadata itself does return -1 on error.
mfu_copy_set_metadata does things like copying ownership, permissions, acls, and timestamps.
Should callers set their own local rc = -1 if mfu_copy_set_metadata returns -1?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in mfu_flist_copy.c by locating every caller of mfu_copy_set_metadata and reading how each caller currently handles its return value. Trace the existing rc handling, then confirm that metadata failures are reflected by the caller's result in every affected function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100