houqp / houqp/sqlvet

`go.mod` of `v1.1.8` out of date

Open
#40 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
500
Forks
29
PR merge metrics
No merged PRs in 30d

Description

As of the newest commit, go.mod has:

https://github.com/houqp/sqlvet/blob/5f05ce8ee30db3e0b2bd1ba6786ee20bdfc7d7da/go.mod#L9

However, v1.1.8 (aka latest) still has:
https://github.com/houqp/sqlvet/blob/de3040a06e0198e67a8ebcaba67095c601f42d81/go.mod#L9

This version of pg_query_go leads to the following compilation error:

$ go install github.com/houqp/sqlvet@latest
go: downloading github.com/houqp/sqlvet v1.1.8
go: downloading github.com/logrusorgru/aurora v2.0.3+incompatible
go: downloading github.com/sirupsen/logrus v1.9.0
go: downloading github.com/pganalyze/pg_query_go/v4 v4.2.0
go: downloading golang.org/x/tools v0.13.0
go: downloading golang.org/x/tools/go/pointer v0.1.0-deprecated
go: downloading golang.org/x/sys v0.12.0
go: downloading golang.org/x/mod v0.12.0
go: downloading github.com/golang/protobuf v1.5.0
go: downloading google.golang.org/protobuf v1.33.0
# github.com/pganalyze/pg_query_go/v4/parser
src_port_snprintf.c:374:1: error: conflicting types for ‘strchrnul’; have ‘const char *(const char *, int)’
  374 | strchrnul(const char *s, int c)
      | ^~~~~~~~~
In file included from go/pkg/mod/github.com/pganalyze/pg_query_go/v4@v4.2.0/parser/include/c.h:61,
                 from src_port_snprintf.c:62:
/usr/include/string.h:286:14: note: previous declaration of ‘strchrnul’ with type ‘char *(const char *, int)’
  286 | extern char *strchrnul (const char *__s, int __c)
      |              ^~~~~~~~~

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the dependency entry in go.mod at the current commit with the v1.1.8 commit referenced in the issue. Start by running go install github.com/houqp/sqlvet@latest to reproduce the pg_query_go compilation error; update the released dependency metadata so the latest installation builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.