hotwired / hotwired/hotwire-native-android
3-button navigation bar overlaps the webview content
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 163
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
If a device's navigation mode is set to "3 (or 2)-button navigation", the navigation bar covers the the webview:
A workaround is to add some padding to the web page, as https://hotwire-native-demo.dev/ does:
However, it would be nice to have a proper fix.
It looks like the existing applyDefaultImeWindowInsets function should be using smth like maxOf(imeInsets.bottom, systemBarInsets.bottom) for the bottom inset.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing applyDefaultImeWindowInsets function and reproduce the issue on an Android device using 3- or 2-button navigation. Inspect how IME and system-bar bottom insets are applied to the webview. Done means the navigation bar no longer covers webview content without requiring page-level padding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100