hotwired / hotwired/hotwire-native-android

Backing does not run the RouteDecisionHandlers

Open
#142 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
163
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Fairly similar issue to https://github.com/hotwired/hotwire-native-android/issues/140
We're trying to implement RevenueCat, which runs its own native UI
We've tried overiding the UI with our native bit - Router.Decision.NAVIGATE overlaps the old web-based version.
When navigating away from the native screen, and then backing into that previously overlaped url, the native version doesn't show up

That seems to be because we delegate the pop to the NavController, which does not run the destinations

https://github.com/hotwired/hotwire-native-android/blob/43830730e3e21769422a0d48228c6dc40c5deda6/navigation-fragments/src/main/java/dev/hotwire/navigation/navigator/Navigator.kt#L116

https://github.com/hotwired/hotwire-native-android/blob/43830730e3e21769422a0d48228c6dc40c5deda6/navigation-fragments/src/main/java/dev/hotwire/navigation/navigator/Navigator.kt#L377C17-L377C35

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the related issue 140 and inspect Navigator.kt at the linked lines around 116 and 377, focusing on how backing delegates to NavController and handles destinations. Reproduce the native-screen navigation flow described in the issue; done means backing into the overlapping URL invokes the RouteDecisionHandlers so the native UI appears instead of the web version.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.