home-assistant / home-assistant/core
dmaker.fan.{p15,p18} not available, but supported by the upstream library
- Dominant language
- Python
- Stars
- 90.5k
- Forks
- 38.6k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 597
Description
### The problem
Hi there, I bought the following model:
Xiaomi Mi Smart Standing Fan Pro
I thought that this model is supported in the HA documentation:
> Standing Fan Pro | dmaker.fan.p11
But it shows as `dmaker.fan.p15` for class `FanMiot`
maybe a newer revision?
According to this, that model should be supported:
https://github.com/syssi/xiaomi_fan/blob/develop/README.md
> Pedestal Fan Fan P15 | dmaker.fan.p15
in version:
```
"name": "Xiaomi Mi Smart Pedestal Fan",
"version": "2022.4.0.0",
```
But in HA that is not supported:
```
2022-06-14 19:15:27 WARNING (SyncWorker_7) [miio.device] Found an unsupported model 'dmaker.fan.p15' for class 'FanMiot'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/
2022-06-14 19:15:27 WARNING (SyncWorker_7) [miio.miot_device] Unable to find mapping for dmaker.fan.p15, falling back to dmaker.fan.1c
```
In the code of fan.py the P15 seems to work in the same way as the P11 does:
```
elif model in [MODEL_FAN_P11, MODEL_FAN_P15]:
fan = FanMiot(host, token, model=MODEL_FAN_P11)
device = XiaomiFanMiot(
name, fan, model, unique_id, retries, preset_modes_override
)
```
Could the P15 be enabled in the HA integration?
Sebastian
### What version of Home Assistant Core has the issue?
Home Assistant Core 2022.6.5
### What was the last working version of Home Assistant Core?
none
### What type of installation are you running?
Home Assistant OS
### Integration causing the issue
Xiaomi_Miio
### Link to integration documentation on our website
https://www.home-assistant.io/integrations/xiaomi_miio/
### Diagnostics information
[config_entry-xiaomi_miio-0caca181497a40008b372a614aab2503.json.txt](https://github.com/home-assistant/core/files/8902184/config_entry-xiaomi_miio-0caca181497a40008b372a614aab2503.json.txt)
### Example YAML snippet
```yaml
./.
```
### Anything in the logs that might be useful for us?
```txt
2022-06-14 19:15:27 WARNING (SyncWorker_7) [miio.device] Found an unsupported model 'dmaker.fan.p15' for class 'FanMiot'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/
2022-06-14 19:15:27 WARNING (SyncWorker_7) [miio.miot_device] Unable to find mapping for dmaker.fan.p15, falling back to dmaker.fan.1c
```
### Additional information
I tried to set it up as P11 (asked for mapping during setup of the integration) and it is shown on the device page:

But the log above tells a different story --> another bug, that this is not working in the way intended?
2022-06-14 19:15:27 WARNING (SyncWorker_7) [miio.miot_device] Unable to find mapping for dmaker.fan.p15, falling back to dmaker.fan.1c
Contributor guide
Assessment
This issue has not been assessed yet.