home-assistant / home-assistant/android

Retrofit should be not exposed outside of common module

Open
#5,421 3 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Kotlin
Stars
3.9k
Forks
1.1k
Avg merge
1d 12h
Merged PRs (30d)
81

Description

Today `retrofit` is an `api` dependency of `:common`. It should be an internal dependency there is no reason to expose it. The only usage is about an exception catching in another Gradle module. We could simply catch the exception in common and rethrow our own error.

**Expectation**
- `retrofit` is now a `implementation` dependency of `:common`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.