home-assistant / home-assistant/android
WebSocket sendBytes should supports a buffer more than 16MiB
Open
enhancement
- Dominant language
- Kotlin
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 81
Description
_Originally posted by @TimoPtr in https://github.com/home-assistant/android/pull/5219#discussion_r2068500345_
Currently we are not checking the size of the buffer we send over `sendBytes` and if it goes above 16MiB it won't be send and the socket will close leading to undefined behavior within the app.
We should check the size of the buffer and send it in multiple batch. To do that we need to check with core if it is supported to send the data in batch.
Contributor guide
Assessment
This issue has not been assessed yet.