home-assistant-libs / home-assistant-libs/zwave-js-server-python
TODO: Remove redundant validation
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 63
- Forks
- 26
- Avg merge
- 13h 14m
- Merged PRs (30d)
- 10
Description
Z-Wave JS does a lot of internal validation that we have attempted to replicate within the library, and in some cases we may have been overly strict. Where it makes sense, we should fallback to the driver validation. To accomplish this we will need to make sure that whatever cases that lead to an exception and would also return an error from zwave-js are removed from the library.
CC @MartinHjelmare as this is something we have tackled here or there, but I think this is an overall design decision we should align on
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by inventorying the library's validation paths and comparing their exception cases with the errors returned by the Z-Wave JS driver; done means redundant checks are removed where the driver already validates the same cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100