holoviz / holoviz/param

Clobbered class names in ClassSelector.get_range

Open
#1,087 0 comments 0 reactions 0 assignees View on GitHub
type-bug
Dominant language
Python
Stars
521
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
35

Description

We found out that classes with the same name (e.g. in different files) get clobbered in `concrete_descendents`. We extended `descendents` with a `concrete` parameter, and added a warning in `concrete_descendents` (https://github.com/holoviz/param/pull/1035/).

We have a problem with `ClassSelector.get_range`, where classes with the same name are still clobbered. Options include:
- Updating somehow the returned type to a list of tuples
- Creating another method like range that doesn't suffer from this problem
- Returning a MultiDict
- etc.

A couple of difficulties with `get_range`:
- It's implemented by other `Selector` subclasses, so I guess their return type should be identical, or at least behave the same way
- It's used quite a bit internally by Panel at least (maybe more, to be checked)

So this needs a nice transition plan.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.