holochain / holochain/android-service-runtime

Handle nullables with errors, not panics

Open
#107 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4
Forks
2
Avg merge
1d 5h
Merged PRs (30d)
3

Description

In several parts of the kotlin code, we are using `!!` to assert a value is not null. If the value is null, this will panic.

AC:
- Throw exceptions if value is null when it should be defined

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Kotlin code paths that use `!!` and inspect what each nullable value represents before deciding which exception behavior is appropriate. Replace null assertions with exceptions where null indicates an invalid state, then verify that the affected paths no longer panic and that the acceptance criterion is met.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.