holepunchto / holepunchto/hypercore

`core.purge` throws error

Open
#703 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
211
Avg merge
5h 49m
Merged PRs (30d)
9

Description

Seems it's trying to call a method that no longer exists: _closeAllSessions.

https://github.com/holepunchto/hypercore/blob/46975c3726af3c15366b3dd807a39fafc3383a59/index.js#L810

It'd be nice to have the method throw a more straightforward error or remove it entirely.
Getting this when trying to purge data in the latest hyperdrive via drive.purge()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in index.js around line 810 and trace core.purge to the call to _closeAllSessions. Reproduce the failure through hyperdrive's drive.purge(), then verify the chosen behavior: either the obsolete method is removed or purge reports a straightforward error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.