holdenk / holdenk/spark-testing-base

Returning nulls for nullable types

Open
#302 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.6k
Forks
357
PR merge metrics
No merged PRs in 30d

Description

I noticed that DataFrameGenerator always returns a non-null value, even for columns which are nullable.
Is this the desired behavior?
If not, I would write a PR to change this 😃

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with core/src/main/1.3/scala/com/holdenkarau/spark/testing/DataframeGenerator.scala around lines 111-138, as linked in the issue. Check how nullable columns are handled and whether related generator behavior or tests define the expected result. Done means the project has a decided and verified behavior for nullable columns, including coverage for the chosen result.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
data, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.