hoffstadt / hoffstadt/DearPyGui

Chinese path support for select_directory_dialog

Open
#299 15 comments 0 reactions 1 assignee Claimed by @Pcothren View on GitHub
priority: high state: ready type: bug
Dominant language
C++
Stars
15.6k
Forks
783
PR merge metrics
No merged PRs in 30d

Description

**Version of Dear PyGui:**
[DearPyGui Version] 0.5.53
[Python Version] 3.9.0
[DearImGui Version] 1.79
[Compiler] MSVC version 1927

**OS**

Operating System: Windows 10

**My Issue/Question**
You can see the path with Chinese character is appear as ?? even I tried
`add_additional_font('WeiRuanYaHei.ttf', 18, glyph_ranges='chinese_simplified_common')`
which only solve the main interface supporting not the select_directory_dialog.

if path with this is selected, DPG will exit without raising any Exception.

I try to dig into the source code of select_directory_dialog in dearpygui, but could not found it.

![image](https://user-images.githubusercontent.com/54829297/97805966-37b0c000-1c94-11eb-928d-4a779bc179c5.png)

A clear and concise description of what the issue/question is. Please provide as much context as possible.

**To Reproduce**

try to create a director with charactor "我的程序", and using select_directory_dialog to select it and press OK.

**Expected behavior**

normal

**Screenshots/Video**

see above

**Standalone, minimal, complete and verifiable example:**

```python
# Here's some code anyone can copy and paste to reproduce your issue
def directory_picker(sender, data):
select_directory_dialog(callback=apply_selected_directory)

def apply_selected_directory(sender, data):
# log_debug(data) # so we can see what is inside of data
directory = data[0]
folder = data[1]
set_value("directory", directory)
set_value("folder", folder)
set_value("folder_path", f"{directory}\\{folder}")`

with window('test):
add_button("Folder", callback=directory_picker)

start_dearpygui()
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.