hluk / hluk/CopyQ

toggling 'Important' tag twice doesn't remove "{Remove a, Clear all} tags"

Open
#2,959 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
12.3k
Forks
593
Avg merge
2d 8h
Merged PRs (30d)
9

Description

**Describe the bug**
This is by no means anything serious, but a minor QoL issue.

Pressing `Toggle tag "Important"` twice will add & remove said tag which works correctly. However the first press (which adds the tag) also creates `Remove a tag` & `Clear all tags` icons on the toolbar. My understanding is these two buttons should be removed on the second toggle, as the item no longer has any tags.

**To Reproduce**
- create a new entry in copyq by copying something
- open copyq
- press `Toggle tag "Important"`
- note `Remove a tag` & `Clear all tags` icons appear on the UI
- press `Toggle tag "Important"`
- note added icons/buttons do not disappear

**Expected behavior**
`Remove a tag` & `Clear all tags` icons get removed once all tags are removed.

**Repro recording**

https://github.com/user-attachments/assets/226594e5-a60e-40dd-bb86-a935180bd2d0

**Version, OS and Environment**
```
v9.1.0
Qt: 6.7.2
OS: Debian GNU/Linux trixie/sid
DE/DM: i3wm
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.