histoire-dev / histoire-dev/histoire

responsiveDisabled prop on Story does not do anything

Open
#524 0 comments 1 reaction 0 assignees View on GitHub
to triage vue2
Dominant language
TypeScript
Stars
3.6k
Forks
212
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug

I have added the prop `responsive-disabled` to the `` component and it is not doing anything. The responsive option is still present in the top bar.

![image](https://user-images.githubusercontent.com/25989331/234356413-687ec7a5-065d-4b33-a4fd-9d1c6c0d8394.png)

### Reproduction

Create a fresh histoire project and create one story with `responsive-disabled` prop.

E.g.:

### histoire.config.ts

```ts
import { defineConfig } from 'histoire'
import { HstVue } from '@histoire/plugin-vue2'

export default defineConfig({ plugins: [HstVue()]})
```

### test.story.vue

```vue



Hello world!

```

### System Info

```shell
System:
OS: macOS 13.3.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 1.17 GB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 16.18.1 - ~/.nvm/versions/node/v16.18.1/bin/node
Yarn: 1.22.15 - ~/.yarn/bin/yarn
npm: 8.19.2 - ~/.nvm/versions/node/v16.18.1/bin/npm
Browsers:
Brave Browser: 110.1.48.171
Chrome: 112.0.5615.137
Firefox: 112.0.1
Safari: 16.4
npmPackages:
@histoire/controls: ^0.16.1 => 0.16.1
@histoire/plugin-vue2: ^0.16.1 => 0.16.1
@vitejs/plugin-vue2: ^2.2.0 => 2.2.0
histoire: ^0.16.1 => 0.16.1
vite: ^4.3.1 => 4.3.1
```
```

### Used Package Manager

npm

### Validations

- [X] Follow our [Code of Conduct](https://github.com/histoire-dev/histoire/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/histoire-dev/histoire/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://histoire.dev/guide/).
- [X] Check that there isn't [already an issue](https://github.com/histoire-dev/histoire/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/histoire-dev/histoire/discussions).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in a fresh Histoire project using histoire.config.ts and test.story.vue with the example. Start by tracing how the Story prop affects the top bar, then verify that the responsive option is absent when the prop is set.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vite
Domain
devtools, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.