hirokazutei / hirokazutei/react-native-spacing-system

[FEATURE]: Ability to set acceptable responsibility for Inset

Open
#134 0 comments 0 reactions 1 assignee Claimed by @hirokazutei View on GitHub
enhancement flow good first issue ts
Dominant language
TypeScript
Stars
42
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Given the type of style props that you can pass to `View` there are tiers of what should be accepted and what shouldn't.

**Too Strict: Inset Handles Padding Only**
- Padding Props

**Strict: Inset Handles Padding and Layout**
- Flex Styles
- Image Related Layout

**Reasonable: Inset Handles Spacing and Layout**
- View Sizes
- Positional Styles

**Too Loose: Inset Handles Everything**
- Border Styles
- Color Styles
- Margin / Padding Styles

The **Too Loose** level would defeat the purpose of the library by allowing the user of the library to break consistency rules of making `Inset` handle padding (and margin) in multiple ways as well as having other non-layout and spacing related stylistic responsibilities. On the other hand, the **Too Strict** level would make the library cumbersome and difficult to use.

However, I think between **Too Strict** and **Reasonable* there is a line that the user should be able to draw.
Being able to declare what `Inset` is for each user would make the library a bit less opinionated but still fall within the original philosophy of splitting up responsibilities of the all-powerful `View` component.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.