higlass / higlass/higlass-server

request.data.get('datafile') vs request.data['datafile']?

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
22
Forks
22
PR merge metrics
No merged PRs in 30d

Description

`request.data.get('datafile')` won't fail immediately if the field is missing, but it will fail just below, at `datafile.name`. Is there a reason for the `get`? and it looks like we're expecting either name or datafile, but not both, but one is required?

views.py:
```python
datafile_name = self.request.data.get('datafile').name

if 'name' in self.request.data:
name = self.request.data['name']
else:
name = op.split(datafile_name)[1]
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.