higlass / higlass/higlass-python

`Tileset.tiles` return annotation is incorrect

Open
#225 0 comments 0 reactions 1 assignee Claimed by @manzt View on GitHub
Dominant language
Python
Stars
66
Forks
11
PR merge metrics
No merged PRs in 30d

Description

The `tiles` method is annotated as returning a list of dicts:

* https://github.com/higlass/higlass-python/blob/main/src/higlass/tilesets.py#L171
* https://github.com/higlass/higlass-python/blob/main/src/higlass/tilesets.py#L223

but the handler that consumes it actually unpacks (tile_id, tile) pairs:

* https://github.com/higlass/higlass-python/blob/main/src/higlass/_widget.py#L83

Returning `list[dict]` makes the dict comprehension raise an error that gets swallowed (see companion issue) so no response is sent and the UI reports "Tileset info not found".

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.