highsource / highsource/jsonix

define wrapper blocks webpack2

Open
#171 13 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
369
Forks
85
PR merge metrics
No merged PRs in 30d

Description

The current define wrapper in JSONIX blocks usage in webpack2, I wonder if it's time to get rid of this?
![selection_273](https://cloud.githubusercontent.com/assets/319678/26314448/49ec500c-3f0e-11e7-97be-857945c7e794.png)

```
/*if (typeof define !== 'function') {^M
// Load the define function via amdefine^M
var define = require('amdefine')(module);^M
// If we're not in browser^M
if (typeof window === 'undefined')^M
{^M
// Require xmldom, xmlhttprequest and fs^M
define(["xmldom", "xmlhttprequest", "fs"], _jsonix_factory);^M
}^M
else^M
{^M
// We're probably in browser, maybe browserify^M
// Do not require xmldom, xmlhttprequest as they'r provided by the browser^M
// Do not require fs since file system is not available anyway^M
define([], _jsonix_factory);^M
}^M
}^M
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.