hiero-ledger / hiero-ledger/hiero-sdk-python

feat(tck): implement deleteContract JSON-RPC method

Open
#2,601 4 comments 0 reactions 0 assignees View on GitHub
approved lang: python scope: TCK skill: intermediate
Dominant language
Python
Stars
63
Forks
298
Avg merge
3d 18h
Merged PRs (30d)
38

Description

**Problem**

The TCK server does not implement `deleteContract`, so the TCK driver's `ContractDeleteTransaction` suite cannot run against the Python SDK. The SDK transaction already exists: `src/hiero_sdk_python/contract/contract_delete_transaction.py` (`ContractDeleteTransaction`).

**Blocked by #2594 (`createContract`)** — it creates the contract-service TCK modules, and this suite needs a contract to delete.

**Before you start — required reading**

TCK handlers are contract work: the TCK driver validates exact parameter names, optionality, defaults, and error semantics against the published spec. Please do not code from this issue title alone (or paste it into an AI tool and ship the first thing that runs) — read these first:

1. **The spec page linked below**, in full — especially the parameter table, the expected response shape, and the error/edge-case tests. If your handler's behavior differs from the spec table, the TCK suite will fail even if the happy path works.
2. [`tck/README.md`](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/tck/README.md) — how the JSON-RPC server, param dataclasses, handler registry, and responses fit together, and how to run the TCK driver locally against your handler. Run the actual TCK suite before opening a PR; unit tests alone are not enough.
3. **An existing handler as your pattern** — pick the closest one in `tck/handlers/` with its matching `tck/param/` dataclass and follow its structure, naming, and error handling exactly. Do not invent a new style, and do not re-implement SDK logic in the handler — handlers only wire validated params onto the existing SDK transaction/query.
4. **The SDK class you are wrapping** (path in the Problem section) — read its setters and defaults so you know what the SDK already handles for you.
5. [`CONTRIBUTING.md`](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/CONTRIBUTING.md) — test and PR conventions.

**Solution**

- [ ] Add a `DeleteContractParams` dataclass to `tck/param/contract.py` (`contractId`, transfer target — account ID *or* contract ID per the spec, permanent-removal flag if specified, `commonTransactionParams`).
- [ ] Add a `deleteContract` handler registered via `@rpc_method("deleteContract")`, returning `status` via the status-only response pattern.
- [ ] Add unit tests under `tests/tck/`, then run the TCK driver's ContractDeleteTransaction suite locally.

**Acceptance criteria**

- [ ] `deleteContract` registered and dispatchable
- [ ] Both transfer targets (account and contract) handled per the spec
- [ ] Spec error cases behave as specified (missing/invalid `contractId`, immutable contract, missing admin-key signature, invalid transfer target)
- [ ] Unit tests added and the TCK `ContractDeleteTransaction` suite passes

Spec: https://github.com/hiero-ledger/hiero-sdk-tck/blob/main/docs/test-specifications/contract-service/ContractDeleteTransaction.md
JS reference: https://github.com/hiero-ledger/hiero-sdk-js/blob/main/tck/methods/contract.ts (`deleteContract`)

Contributor guide

Open the contributing guide

Research direction

Read the ContractDeleteTransaction spec, tck/README.md, the existing handlers in tck/handlers/, and src/hiero_sdk_python/contract/contract_delete_transaction.py. Add DeleteContractParams in tck/param/contract.py, register the deleteContract JSON-RPC handler, and add tests under tests/tck/. Done means both transfer targets and specified errors work and the TCK ContractDeleteTransaction suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend-api-design, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.