hiero-ledger / hiero-ledger/hiero-sdk-java

Re-enable disabled tests in ContractFunctionParametersTest and MockingTest

Open
#2,873 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
264
Forks
192
Avg merge
2d
Merged PRs (30d)
39

Description

Two unit tests are disabled with a bare `@Disabled` and no explanation:

- `ContractFunctionParametersTest.bigIntChecks()` ("BigInteger checks") — `sdk/src/test/java/com/hedera/hashgraph/sdk/ContractFunctionParametersTest.java:517`
- `MockingTest.defaultMaxQueryPaymentTest()` ("Client.setDefaultMaxQueryPayment() functions correctly") — `sdk/src/test/java/com/hedera/hashgraph/sdk/MockingTest.java:649`

Both cover behavior we want regression protection on: int256 boundary handling in `ContractFunctionParameters`, and client-level default query payment limits.

Scope: run each locally, dig up why it was turned off (git blame the `@Disabled` line), then either fix the underlying problem and re-enable, or keep it disabled with a `@Disabled("reason")` string plus a linked issue so the gap is documented instead of silent.

Contributor guide

Open the contributing guide

Research direction

Start with sdk/src/test/java/com/hedera/hashgraph/sdk/ContractFunctionParametersTest.java:517 and MockingTest.java:649. Run bigIntChecks() and defaultMaxQueryPaymentTest(), then use git blame on each @Disabled line to find why it was added. Done means either fixing the underlying problem and re-enabling both tests, or adding specific reasons and linked issues to document any remaining gap.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.