hiero-ledger / hiero-ledger/hiero-sdk-java

Some generated protobuf classes are not put in SDK scoped package

Open
#2,561 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
264
Forks
192
Avg merge
2d
Merged PRs (30d)
39

Description

### Description

Most generated protobuf classes are in `com.hedera.hashgraph.sdk.proto` package so when a project depends on both the SDK and `hedera-protobuf-java-api` there will be potential clash as the classes generated from the following files will have the same FQCNs:

```
crs_publication.proto:option java_package = "com.hedera.hapi.services.auxiliary.hints.legacy";
event_consensus_data.proto:option java_package = "com.hedera.hapi.platform.event.legacy";
event_core.proto:option java_package = "com.hedera.hapi.platform.event.legacy";
event_descriptor.proto:option java_package = "com.hedera.hapi.platform.event.legacy";
event_transaction.proto:option java_package = "com.hedera.hapi.platform.event.legacy";
gossip_event.proto:option java_package = "com.hedera.hapi.platform.event.legacy";
hints_key_publication.proto:option java_package = "com.hedera.hapi.services.auxiliary.hints.legacy";
hints_partial_signature.proto:option java_package = "com.hedera.hapi.services.auxiliary.hints.legacy";
hints_preprocessing_vote.proto:option java_package = "com.hedera.hapi.services.auxiliary.hints.legacy";
history_proof_key_publication.proto:option java_package = "com.hedera.hapi.services.auxiliary.history.legacy";
history_proof_signature.proto:option java_package = "com.hedera.hapi.services.auxiliary.history.legacy";
history_proof_vote.proto:option java_package = "com.hedera.hapi.services.auxiliary.history.legacy";
state_signature_transaction.proto:option java_package = "com.hedera.hapi.platform.event.legacy";
tss_encryption_key.proto:option java_package = "com.hedera.hapi.services.auxiliary.tss.legacy";
tss_encryption_keys.proto:option java_package = "com.hedera.hapi.node.state.tss.legacy";
tss_message.proto:option java_package = "com.hedera.hapi.services.auxiliary.tss.legacy";
tss_message_map_key.proto:option java_package = "com.hedera.hapi.node.state.tss.legacy";
tss_vote.proto:option java_package = "com.hedera.hapi.services.auxiliary.tss.legacy";
tss_vote_map_key.proto:option java_package = "com.hedera.hapi.node.state.tss.legacy";
```

### Steps to reproduce

per the description

### Additional context

_No response_

### Hedera network

other

### Version

v2.65.0

### Operating system

None

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.