hiero-ledger / hiero-ledger/hiero-sdk-cpp
Wire EthereumFlow EIP-1559 signing to populate recoveryId
- Dominant language
- C++
- Stars
- 42
- Forks
- 108
- Avg merge
- 11h 45m
- Merged PRs (30d)
- 2
Description
Summary:
EthereumFlow currently does not populate `EthereumTransactionDataEip1559::mRecoveryId` when signing.
This follow-up issue wires the EIP-1559 path in `EthereumFlow` (if applicable) to compute `recoveryId` using
`ECDSAsecp256k1PrivateKey::getRecoveryId(...)` and ensure `yParity` is included in the serialized bytes.
Acceptance:
- `EthereumFlow` signing path computes `recoveryId` after signing
- EIP-1559 `yParity` byte is populated in `EthereumTransactionDataEip1559`
- No behavior change for legacy Ethereum transaction types
Follow-up from [PR#1649](https://github.com/hiero-ledger/hiero-sdk-cpp/pull/1649)
Contributor guide
Research direction
Start with the EthereumFlow signing path and compare the EIP-1559 handling with follow-up PR#1649. Trace ECDSAsecp256k1PrivateKey::getRecoveryId(...) and EthereumTransactionDataEip1559::mRecoveryId, then verify that EIP-1559 serialization includes yParity while legacy transaction behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- blockchain, cryptography
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 67/100