hiero-ledger / hiero-ledger/hiero-consensus-node

Merge Queues

Open
#21,587 0 comments 0 reactions 1 assignee Assigned to @andrewb1269 View on GitHub
github_actions
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

Implement Merge Queues to ensure `main` integrity and reliability.

Infrastructure enablers:
- [x] Relabel the cluster to ensure MQPT available
- [x] Add new MQPT to cleanout workflow
- PR for #23486 to implement this
- [x] Ensure documentation is updated to reflect the IDs of the new MQPT
- Are we tying specific machines to specific network IDs or not?
- [x] Add Merge Queue runners to CN repo

List of checks expected to run before merging:
- [x] Create `trunk.yaml` config file with required checks. #23478
- [x] Create a new `trunk.yaml` workflow file for triggering the checks that do not trigger by default PRs. #23542
- [x] MATS
- Will run by default on the Trunk PR when the new PR is created
- [x] XTS
- All mandatory XTS checks
- [x] ~~Add a new trigger to XTS Dry Run workflow to call with all required checks~~ #23479
- [x] Implement by adding to the new `trunk.yaml` workflow file
- [x] Mini Performance and Longevity
- [x] Will be handled by Alex's mini longevity workflow in #21746
- [x] Link in Mini Perf workflow to Merge Queues in `trunk.yaml` config file. #23938
- [x] Add variable to increment through which Dallas MQPT cluster we are on #23823
- [x] Dallas_n10, Dallas_n11, Dallas_n12
- [x] Use GH Action to update the namespace var
- [x] Create variable `MQPT_CLUSTER`
- ~~[ ] Remove variable for Dallas MQPT cluster and replace with concurrency in the workflow.~~ #24179
- [x] Switch to only `Dallas_n10` cluster and remove cluster iteration from MQPT Controller workflow. #24184
- [x] Add Gradle and Docker Determinism checks to Merge Queues #24192
- [x] Add Snyk check to Merge Queues #24258

List of changes that will not require a PR:
- [ ] Update `main` branch permissions to only `trunk.io` App and admin for merging (see `solo` repo for example).
- [ ] Update the batch size in config from 2 PRs to 8 PRs
- [ ] Update max wait time in Trunk config from 1 min to 1 hour
- [ ] Create training and documentation for rollout to users

After Merge Queues are deployed:
- [ ] Remove REQUIREMENT for Codacy, Codecov, and Snyk passing in PR checks (still run them, but non-blockers for adding a PR to merge queue) - This will also remove the requirement for the `mirror-pr` utility.

Related Items:
Ties to issue [here](https://github.com/hiero-ledger/roadmap/issues/55)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.