hiero-ledger / hiero-ledger/hiero-consensus-node

Consider externalizing queues from RpcPeerProtocol to separate classes

Open
#20,157 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

During review, it was noted that RpcPeerProtocol has too many responsibilities and should be split into smaller classes - in particular, queues should be external, so they can be injected into RpcPeerProtocol and RpcPeerHandler and be a communication point between them, rather than having everything in single place. This will add considerable complexity to the system, but might result in cleaner design.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.