hiero-ledger / hiero-ledger/hiero-consensus-node

Modify the birth round ancient threshold

Open
#19,078 0 comments 0 reactions 1 assignee Claimed by @lpetrovic05 View on GitHub
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

Currently, for both generation ancient and birth round ancient we keep a list of minimum judges for each round, and define ancient based on that list. With birth rounds, this is unnecessary, we can simply subtract `X` from the minimum birth round of all judges in the latest decided round to get the ancient boundary.

In order for this to work on restart/reconnect, we need to keep the birth rounds of all judges in the consensus snapshot. This means that we should replace `JudgeId` with `EventDescriptor` for the judges.

To simplify this task, some cleanup can be done. `judgeHashes` can be removed from the consensus snapshot since it has been previously replaced by `judgeIds`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.