hiero-ledger / hiero-ledger/hiero-consensus-node

Allowance pricing configuration

Open
#18,911 2 comments 0 reactions 1 assignee Claimed by @joshmarinacci View on GitHub
Dominant language
Java
Stars
407
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

### Background

In the current design a user can Approve multiple allowances in a single transaction. The original intention was that each created allowance would cost the list pricing of $0.05. So if 3 allowances were created in a single transaction then the charged fee for the transaction would be ~$0.15. The logic for this is that 3 allowances is three times the work, therefore 3 times the cost.
However in the current design additional allowances just add a small incremental price to the transaction price of $0.05. For example [here](https://hashscan.io/testnet/transaction/1744931932.758252987) is a transaction with a single allowance and the charged fee is $0.04977. Then we have a transaction [here](https://hashscan.io/testnet/transaction/1744932758.065551000) with 3 allowances and the price is $0.0568.

### Acceptance Criteria

1. An AccountAllowanceApproveTransaction with 1 allowance has a charged fee of ~$0.05
2. An AccountAllowanceApproveTransaction with 3 allowances has a charged fee of ~$0.15
3. An AccountAllowanceApproveTransaction with 5 allowances has a charged fee of ~$0.25

### Dependencies

We might want to make this change after we have implemented the proposed clean fees.

### Definition of Ready (DoR) Checklist

- [x] Clear acceptance criteria
- [ ] Clear and detailed description
- [ ] Dependencies identified
- [ ] Links to documentation
- [ ] Should be completable in 2-3 Days
- [ ] Initial draft of Low-level design document
- [ ] At least high level test plan
- [ ] Groomed/Estimated

### Definition of Done (DoD) Checklist

- [x] Acceptance Criteria complete
- [ ] No Codacy issues greater than minor (in new code)
- [ ] JavaDocs updated/created
- [ ] Code commented
- [ ] Unit tests created/updated
- [ ] 80% test code coverage (in new code)
- [ ] Happy Path and major negative cases in HAPI tests as applicable

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.