hiero-ledger / hiero-ledger/hiero-consensus-node

Remove genesis.properties

Open
#18,804 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

### Background

```
public Bytes genesisNetworkProperties(@NonNull final Configuration config) {
final var servicesConfigList =
ServicesConfigurationList.newBuilder().nameValue(List.of()).build();
return ServicesConfigurationList.PROTOBUF.toBytes(servicesConfigList);
}
```
Doesn't utilize config, so any overrides are not put into state at genesis.
This may result in a node that reconnects will have different properties if there were overrides in application.properties or genesis.properties.

### Acceptance Criteria

- Remove genesis.properties and see how this may impact JRS tests.
- Make any necessary changes

### Dependencies

_No response_

### Definition of Ready (DoR) Checklist

- [ ] Clear acceptance criteria
- [ ] Clear and detailed description
- [ ] Dependencies identified
- [ ] Links to documentation
- [ ] Should be completable in 2-3 Days
- [ ] Initial draft of Low-level design document
- [ ] At least high level test plan
- [ ] Groomed/Estimated

### Definition of Done (DoD) Checklist

- [ ] Acceptance Criteria complete
- [ ] No Codacy issues greater than minor (in new code)
- [ ] JavaDocs updated/created
- [ ] Code commented
- [ ] Unit tests created/updated
- [ ] 80% test code coverage (in new code)
- [ ] Happy Path and major negative cases in HAPI tests as applicable

Contributor guide

Open the contributing guide

Research direction

Start by locating genesisNetworkProperties and all references to genesis.properties, application.properties, and the JRS tests. Run the relevant JRS tests before changing anything, then remove genesis.properties and update any affected tests or configuration handling. Done means the overrides are handled consistently and the JRS tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.