hiero-ledger / hiero-ledger/hiero-consensus-node

Refactor `*ServiceMigrator` and `*SchemaRegistry` classes by extracting common logic

Open
#16,468 0 comments 0 reactions 1 assignee Claimed by @imalygin View on GitHub
Platform Tech Debt Reduced
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

@tinker-michaelj suggested the following idea as a follow-up for https://github.com/hashgraph/hedera-services/pull/16379 :

> it would be nice at some point if we could extract the common logic between the OrderedServiceMigrator/MerkleSchemaRegistry and FakeServiceMigrator/FakeSchemaRegistry types and reduce duplication between the subprocess and embedded Hedera state lifecycles.

That is, the idea is to consider `OrderedServiceMigrator` / `FakeServiceMigrator` and `MerkleSchemaRegistry` / `FakeSchemaRegistry` pairs, extract common logic to a class that resides in `swirlds-state-impl`. This will help to reduce the logic duplication

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.