hiero-ledger / hiero-ledger/hiero-consensus-node

Only produce `ScheduleCreateOutput#scheduleID` on `IDENTICAL_SCHEDULE_ALREADY_CREATED`

Open
#15,397 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

### Problem

If a `ScheduleCreate` gets `SUCCESS`, it will have a `StateChange` item that shows the id of the created schedule. This means there is no need to set the `CreateScheduleOutput#schedule_id` field in this case.

### Solution

Only set this field when the final status is `IDENTICAL_SCHEDULE_ALREADY_CREATED`.

### Alternatives

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the ScheduleCreate handling and the code that populates CreateScheduleOutput#schedule_id and StateChange items. Trace the final status handling, especially SUCCESS and IDENTICAL_SCHEDULE_ALREADY_CREATED. Done means schedule_id is produced only for IDENTICAL_SCHEDULE_ALREADY_CREATED, while SUCCESS exposes the created schedule ID through StateChange.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.