hiero-ledger / hiero-ledger/hiero-consensus-node

[EPIC] Address future/todo comments that are blocked or need further investigation

Open
#14,679 0 comments 0 reactions 1 assignee Claimed by @stoyanov-st View on GitHub
Epic
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

Address the following future/todo messages

| app/service/contract/impl/test/handlers/ContractCreateHandlerTest.java | 134 | // FUTURE: uncomment this after JKey removal | unknown what this is about |
|---------------------------------------------------------------------------------------------|-----|-------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| app/service/contract/impl/exec/gas/CustomGasCalculator.java | 98 | * FUTURE, Gas for system contract method calls needs to be a) determined by measurement of | Blocked until after fee calculation revamp |
| app/service/contract/impl/exec/TransactionProcessor.java | 218 | // (FUTURE) Once fee charging is more consumable in the HandleContext, we will also want | Blocked until HandleContext changes |
| app/service/contract/impl/exec/systemcontracts/has/isauthorizedraw/IsAuthorizedRawCall.java | 200 | // FUTURE, Get the `Cryptography` engine from the services app via the context (needs to be invented) | Blocked until HIP 632 |
| app/service/contract/impl/exec/systemcontracts/has/isauthorizedraw/IsAuthorizedRawCall.java | 250 | // FUTURE, Determine if in fact input `v` _ever_ has a EIP-155 encoded chain id ... | Blocked until HIP 632 |
| app/service/contract/impl/exec/utils/ActionStack.java | 348 | // (FUTURE) Use builder for simplicity when PBJ lets us set the oneof recipient to UNSET; | blocked until https://github.com/hashgraph/pbj/issues/160 |
| app/service/contract/impl/exec/scope/HandleHederaOperations.java | 230 | // (FUTURE) Needed before enabling contract expiry | blocked until rent |
| app/service/contract/impl/infra/RentCalculator.java | 58 | // TODO - fix this before expiry and rent are enabled | blocked until rent |
| app/service/contract/impl/state/DispatchingEvmFrameState.java | 83 | * TODO - get a little further to clarify DI strategy, then bring back a code cache. | investigate |
| app/service/contract/impl/exec/systemcontracts/FullResult.java | 70 | // Future change reason.protoName() with reason.protoOrdinal() | Investigate |
| app/service/contract/impl/exec/processors/CustomContractCreationProcessor.java | 121 | // TODO - check if a code rule failed before proceeding | investigate |
| app/service/contract/impl/exec/processors/CustomContractCreationProcessor.java | 143 | // TODO - should we revert child records here? | investigate |
| app/service/contract/impl/exec/failure/CustomExceptionalHaltReason.java | 59 | // FUTURE: refactor in the future to be more readable when we start looking for cleanups | cannot be address until grade upgrade per https://github.com/autonomousapps/dependency-analysis-gradle-plugin/issues/1150 |
| app/service/contract/impl/exec/scope/QueryHederaOperations.java | 135 | // TODO - implement correctly | blocked until view function gas pricing is determined

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.